merge process should write CRC to hintfiles #58

Merged
merged 1 commit into from Nov 8, 2012

Conversation

Projects
None yet
3 participants
Member

joecaswell commented Sep 20, 2012

Added calls to close_for_writing where merge process closes files so the CRC is properly appended to the hint file.

Contributor

dizzyd commented Sep 20, 2012

I understand the intent of this patch, but I think it would be better to make sure bitcask_fileops:close/1 does the right thing (i.e. adding CRC to hint file) when it's closing it. It's a slightly better patch but will make more sense to the reader and doesn't depend on knowledge of what's happening in a function so much.

Member

joecaswell commented Sep 20, 2012

bitcask_fileops:close/1 must be able to close both data files, which don't get a final CRC record, and hintfiles which do. I used bitcask_fileops:close_for_writing/1 to have the merge process use the same function as the vnode writer to accomplish the same task

slfritchie merged commit 5abf93c into basho:master Nov 8, 2012

slfritchie was assigned Nov 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment