Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge process should write CRC to hintfiles #58

Merged
merged 1 commit into from
Nov 8, 2012
Merged

merge process should write CRC to hintfiles #58

merged 1 commit into from
Nov 8, 2012

Conversation

joecaswell
Copy link

Added calls to close_for_writing where merge process closes files so the CRC is properly appended to the hint file.

@dizzyd
Copy link
Contributor

dizzyd commented Sep 20, 2012

I understand the intent of this patch, but I think it would be better to make sure bitcask_fileops:close/1 does the right thing (i.e. adding CRC to hint file) when it's closing it. It's a slightly better patch but will make more sense to the reader and doesn't depend on knowledge of what's happening in a function so much.

@joecaswell
Copy link
Author

bitcask_fileops:close/1 must be able to close both data files, which don't get a final CRC record, and hintfiles which do. I used bitcask_fileops:close_for_writing/1 to have the merge process use the same function as the vnode writer to accomplish the same task

slfritchie added a commit that referenced this pull request Nov 8, 2012
merge process should write CRC to hintfiles

Passes all EUnit tests and the new QC model, many thanks!
@slfritchie slfritchie merged commit 5abf93c into basho:master Nov 8, 2012
@ghost ghost assigned slfritchie Nov 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants