Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple enhance and simple bugfix #185

Closed
wants to merge 3 commits into from
Closed

simple enhance and simple bugfix #185

wants to merge 3 commits into from

Conversation

asinbow
Copy link

@asinbow asinbow commented Feb 15, 2012

  1. 1397f15 add node name to text output when ping/stop/restart/reboot.
  2. 86210d9 add ft=erlang to templates for vim recognization.
  3. e465caf ping result no more simply depends on text output, but return value.

@@ -68,7 +68,8 @@ case "$1" in
start)
# Make sure there is not already a node running
RES=`$NODETOOL ping`
if [ "$RES" = "pong" ]; then
ES=$?
if [ "$ES" -ne 0 ]; then
echo "Node is already running!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What 'bug' is this fixing? I don't have an objection if there's an actual reason for the change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please look at #line 139-143

attach)
# Make sure a node IS running
RES=$NODETOOL ping
ES=$?
if [ "$ES" -ne 0 ]; then
...
someone had already use return value($?) instead of text output when pinging before attach.
It's bettter to be the same.
if [ "$ES" -eq 0 ]; then ...
I've made a mistake when use -ne, not -eq.

@dizzyd
Copy link
Contributor

dizzyd commented Aug 30, 2012

I'm ok with 1397f15 (add more info), but the other two patches I'm not really interested in. If you resubmit with just that one patch, I'll be happy to merge.

@dizzyd dizzyd closed this Aug 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants