New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deregistration of services #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned seancribbs
Aug 20, 2012
ghost
assigned joedevivo
Aug 22, 2012
@@ -1,5 +1,6 @@ | |||
{cover_enabled, true}. | |||
{erl_opts, [warnings_as_errors, {parse_transform, lager_transform}]}. | |||
{eunit_opts, [verbose]}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be default in every repo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
+1 |
This was referenced Aug 22, 2012
ghost
assigned seancribbs
Aug 22, 2012
seancribbs
added a commit
that referenced
this pull request
Aug 22, 2012
Add deregistration of services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications that proved PB services should deregister them when shutting down so as to leave a clean state. This also helps when running test suites that start/stop those applications.
Replacing #4, this also serializes registration and deregistration through a
gen_server
process, making the modification of the dispatch table less prone to race conditions.See also: basho/riak_kv#353, basho/riak_kv#354, basho/riak_search#116