Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in riak_core_format:human_time + add test #261

Merged
merged 1 commit into from
Dec 20, 2012
Merged

Fix bug in riak_core_format:human_time + add test #261

merged 1 commit into from
Dec 20, 2012

Conversation

jtuple
Copy link
Contributor

@jtuple jtuple commented Dec 19, 2012

Fix bug with riak_core_format:human_time as well as add test to verify correct results. For example, the expected output of the test values is:

5.0 us
5.0 ms
5.0 s
5.0 min
5.0 hr
5.0 d

which this branch will give you. Whereas master will print:

5.0 us
5.0 ms
5.0 s
300.0 s
18.0 min
7.2 hr

@jtuple jtuple mentioned this pull request Dec 19, 2012
Merged
@ghost ghost assigned jrwest Dec 19, 2012
@jrwest
Copy link
Contributor

jrwest commented Dec 19, 2012

+1

@rzezeski
Copy link
Contributor

+1 from me as well

jtuple added a commit that referenced this pull request Dec 20, 2012
@jtuple
Merge pull request #261 from basho/jdb-fix-format-time
798dc70
@jtuple jtuple merged commit 798dc70 into master Dec 20, 2012
@seancribbs seancribbs deleted the jdb-fix-format-time branch December 20, 2012 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrwest jrwest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtuple @jrwest @rzezeski