Resolve 2I timeout error from case clause #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Welp, I'm having all sorts of fun running the kv eunit tests, but this looks good to me. +1 |
seancribbs
pushed a commit
that referenced
this pull request
Aug 22, 2012
Resolve 2I timeout error from case clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither the HTTP nor the PB interfaces match the
{error, timeout, Acc}return value ofriak_client:wait_for_query_results/3that results from a receive timeout. This case is difficult to reach except in the case of a heavily loaded cluster, which is why it has not been hit before.This changes the return value on timeout to be simply
{error, timeout}. Partial results from a timed out request could be of dubious value and correctness, so the simplest solution is not to return them.