Improper match on w_val_unsatisfied error in HTTP #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned …urn value from riak_kv_put_core.
|
👍 WFM (tested by changing |
|
@russelldb @rzezeski Any objection to merging to 1.2 as well? |
|
No problem for me. |
seancribbs
pushed a commit
that referenced
this pull request
Aug 31, 2012
Improper match on w_val_unsatisfied error in HTTP
|
Cherry-picked to 1.2, didn't want to inadvertantly pull in master commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On put requests, the
riak_kv_put_coreresponds to the client layer with{error, {w_val_unsatisfied, NumW, NumDW, W, DW}}if either W or DW is not met. Inriak_kv_wm_object, the error is attempted to be matched as{error, {w_val_unsatisfied, Requested, Returned}}, which causes the response to be 500 instead of 503.