Use 'tree' style stat names, and riak_core_stat_q #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move backwards compatiblity code to own module for easier deprecation and removal.
Closed
| Key = [element(N, Name) || N <- Fields], | ||
| join(Key). | ||
|
|
||
| recursive_join(BaseName, Aggregates) -> |
There was a problem hiding this comment.
The name recursive_join was a little vague for me. Maybe a comment explaining how it's flattening the nested stat tree, creating a flat list of stats with names prepended by BaseName_?
ghost
assigned Technically there is no bound to the number of buckets one can create, and no limit the length of a bucket name. The erlang atom table is a finite resource and atom sapce is not reclaimed so creating unbounded atoms of any length is a bad idea.
Re-name and better comment confusing `recursive_join` fun. Remove redundant call to `lists:flatten` as once is enough. Correct markdown style escapes to edoc style.
|
Pushed a commit that addresses review comments. |
|
Looks great, +1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use riak core stat query for riak_kv_stat get_stats
Add new read repair dimensioned stat aggregations to stat blob
Depends on riak_core pr - basho/riak_core#252