Fix of float printing in the shell. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: ``` SELECT 555, 1.1, 1e1, 1.123e-2 from GeoCheckin WHERE time > 1452252523182 AND time < 1452252543182 AND region = 'South Atlantic' AND state = 'South Carolina'; ``` Returned ``` +---+--------------------------+--------------------------+--------------------------+ |555| 1.1 | 10.0 | 0.01123 | +---+--------------------------+--------------------------+--------------------------+ |555|1.10000000000000008882e+00|1.00000000000000000000e+01|1.12300000000000003986e-02| +---+--------------------------+--------------------------+--------------------------+ ``` Now it returns: ``` +---+---+----+-------+ |555|1.1|10.0|0.01123| +---+---+----+-------+ |555|1.1|10.0|0.01123| +---+---+----+-------+ ```
|
Thanks @gordonguthrie! |
|
.thumbs.yml config: |
|
+1 |
|
I imagine this should also include a |
hazen
suggested changes
Oct 26, 2016
| @@ -82,7 +82,7 @@ split_lists_by_length(Strings, PerString, MaxLen) -> | |||
| to_list(A) when is_atom(A) -> atom_to_list(A); | |||
| to_list(B) when is_binary(B) -> binary_to_list(B); | |||
| to_list(I) when is_integer(I) -> integer_to_list(I); | |||
| to_list(F) when is_float(F) -> float_to_list(F); | |||
| to_list(F) when is_float(F) -> mochinum:digits(F); | |||
There was a problem hiding this comment.
@macintux Makes a good point. Looks like it's in mochiweb https://github.com/basho/mochiweb/blob/master/src/mochinum.erl#L45-L59
Here's the current dependency:
{mochiweb, "2.9.0.*", {git, "git://github.com/basho/mochiweb.git", {tag, "v2.9.0p2"}}}
There was a problem hiding this comment.
Yeah, not really sure about the rebar.config stuff with riak-shell because clique is a dependency which is also not in rebar.config - did mean to ask about that...
hazen
approved these changes
Oct 26, 2016
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Returned
Now it returns: