Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visiting bad URLs should give a 404 instead of server error #36

Closed
christianp opened this issue Nov 30, 2016 · 4 comments · Fixed by #37
Closed

Visiting bad URLs should give a 404 instead of server error #36

christianp opened this issue Nov 30, 2016 · 4 comments · Fixed by #37

Comments

@christianp
Copy link
Contributor

I was linked to someone's slides on cicero, and didn't know what it was, so I decided to move up a few levels in the URL hierarchy. Every level between the .md file and cicero.xyz gives an internal server error.
Non-matching URLs should give a 404 message, with a link up to cicero.xyz.
christianp added a commit to christianp/cicero that referenced this issue Nov 30, 2016
@christianp
fix reference to homepage in 404.html
01b9573 
the name of the home page is 'git.home', not 'home'.

fixes bast#36
@christianp christianp mentioned this issue Nov 30, 2016
Merged
@bast
Copy link
Owner

bast commented Nov 30, 2016

Thanks for trying it out and reporting! Good point - I will fix that.

@bast bast closed this as completed in #37 Nov 30, 2016
@bast
Copy link
Owner

bast commented Dec 1, 2016

I don't think this is fixed yet. Reopening.

@bast bast reopened this Dec 1, 2016
@bast
Copy link
Owner

bast commented Dec 2, 2016

Sorry - this issue got fixed. I was confused. Thanks again for the fix!

@bast bast closed this as completed Dec 2, 2016
@bast
Copy link
Owner

bast commented Dec 2, 2016

And actually you got a link to my slides. I was absolutely amazed to get the PR while giving the talk. Awesome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix reference to homepage in 404.html christianp/cicero
2 participants
@christianp @bast