implements heuristic for silent sound cards on windows #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on Windows, some soundcards indicate silence by returning zeros. Others however indicate silence by returning no data at all. This commit adds a heuristic output that estimates an appropriate length of zeros when the sound card is not returning any data. The length of the zeros is based on measuring the wall-clock time, and might be off by up to four device periods when the sound card starts/stops playing. This is not usually a problem, however, since we're only missing silence anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on Windows, some soundcards indicate silence by returning zeros. Others however indicate silence by returning no data at all. This commit adds a heuristic output that estimates an appropriate length of zeros when the sound card is not returning any data.
The length of the zeros is based on measuring the wall-clock time, and might be off by up to four device periods when the sound card starts/stops playing. This is not usually a problem, however, since we're only missing silence anyway.