-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few suggestions #46
Comments
Thank you for these suggestions! They are greatly appreciated!
Very cool! If I'm not mistaken, this could be implemented a bit simpler: 08478bb
Sure, why not. This should be easy to implement, and I can't see any downside to it. I have an implementation in 2d68de5, which seems to work on my test cases. Does it work for yours as well?
This is a harder problem. The main issue is that Python dicts can use arbitrary keys, and Matlab structs can not. This is why I opted for Maps instead of structs. Now that I think about it, Python dicts support all kinds of things as keys, and not just strings, which still blows up Matlab, so maybe the current solution is not a good one, either. Do you have an opinion on how to solve this problem better?
This is a very cool idea! The network delay is unavoidable, and in fact I am quite proud of Transplant's performance. Still, your solution would simplify many use cases. I have opened a new issue for this in #48, let's continue the discussion there. |
As playing for a longer time with transplant I have suggestions for a few minor improvements. Maybe you find some of the usefull.
transplant_remote.m
callingnargout(msg('name'))
instead ofnargout(fun)
solves the problem with class methods in some case, so I added this little extension totransplant_remote.m
, maybe you like it:mlab.myfun(option1=value1)
would be called in Matlabmyfun(option1,value1)
. You might not like it though due to ambiguity.struct
data type is far more common than the usage of thecontainers.Map
so it would be nice to make it a bit easyer to work with structures. For example using theMatlabStruct
class in python should be applied recursively to all nested structures. Again it might be again an ambiguity problem.If
A
,B
andC
are large matrices the above command might be limited by the data transfer. It would be nice to specify per function call to keep the result in the proxy in matlab and send only a pointer to python as you are already doing it for objects. For example:The text was updated successfully, but these errors were encountered: