メニュー画面でスキルを使用するとエラーになる不具合を修正 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elleonard
commented
Feb 8, 2023
| @@ -198,6 +198,7 @@ | |||
| */ | |||
|
|
|||
| (() => { | |||
| 'use strict'; | |||
There was a problem hiding this comment.
strictモードを使用していないようだったので、使用してはどうか、という提案になります。
elleonard
commented
Feb 8, 2023
| @@ -211,7 +212,7 @@ | |||
| PluginManager_Parser.prototype.parse = function (params) { | |||
| if (this.isObject(params, "string")) { | |||
| try { | |||
| parseParams = JSON.parse(params) | |||
| const parseParams = JSON.parse(params) | |||
There was a problem hiding this comment.
宣言なしに変数を使おうとしているため、strictモードでは意図通りに動かないコードになっています。
try-catch で例外を握りつぶしているのでぱっと見わかりにくいですが、問答無用で convertNumber に渡されてしまいます。
elleonard
commented
Feb 8, 2023
| @@ -339,7 +340,7 @@ | |||
| } | |||
|
|
|||
| if (inspirationSkills.length) { | |||
| inspirationSkill = inspirationSkills[Math.floor( Math.random() * inspirationSkills.length )]; | |||
| const inspirationSkill = inspirationSkills[Math.floor( Math.random() * inspirationSkills.length )]; | |||
elleonard
commented
Feb 8, 2023
| @@ -339,7 +340,7 @@ | |||
| } | |||
|
|
|||
| if (inspirationSkills.length) { | |||
| inspirationSkill = inspirationSkills[Math.floor( Math.random() * inspirationSkills.length )]; | |||
| const inspirationSkill = inspirationSkills[Math.floor( Math.random() * inspirationSkills.length )]; | |||
| subject.currentAction()._item._itemId = inspirationSkill; | |||
There was a problem hiding this comment.
カプセル化を無視しておりバグの温床となるため、 Game_Action 側に操作を抽象化したメソッドを生やす等、何らかの対処を推奨します。
_inspirationFlag についても同様です。
elleonard
commented
Feb 8, 2023
| @@ -402,7 +403,7 @@ | |||
|
|
|||
| const _Game_BattlerBase_PaySkillCost = Game_BattlerBase.prototype.paySkillCost | |||
| Game_BattlerBase.prototype.paySkillCost = function(skill) { | |||
| if (!this.currentAction()._inspirationFlag) { | |||
| if (!this.currentAction()?._inspirationFlag) { | |||
There was a problem hiding this comment.
currentAction が undefined を返した場合にエラーになっていたので、修正しました。
|
具体的な仕様がコードから読み取れなかったのでノータッチですが、 |
basuka
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
メニュー画面では
Game_Battler.prototype.currentActionからGame_Actionインスタンスではなくundefinedが返るため、メニュー画面で回復スキルなどを使用した際にエラーになります。これを修正するPRになります。