This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
fix ExpressionChangedAfterItHasBeenCheckedError #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should call `updateFilterWidth` in `ngOnInit` instead of `ngAfterViewInit`. The original value (1) of `filterInputWidth` gets bound to the underlying input element before `ngAfterViewInit` is called. If we call `updateFilterWidth`, which updates `filterInputWidth`, in `ngAfterViewInit` we will change a bound input property in the middle of a change detection loop, which angular should detect in dev mode and throw ExpressionChangedAfterItHasBeenCheckedError.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143.
I think we should call
updateFilterWidthinngOnInitinstead ofngAfterViewInit.The original value (1) of
filterInputWidthgets bound to the underlying input element beforengAfterViewInitis called. If we callupdateFilterWidth, which updatesfilterInputWidth, inngAfterViewInitwe will change a bound input property in the middle of a change detection loop, which angular should detect in dev mode and throw ExpressionChangedAfterItHasBeenCheckedError.