Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests for php74 #108

Merged
merged 9 commits into from
Jan 11, 2020
Merged

added tests for php74 #108

merged 9 commits into from
Jan 11, 2020

Conversation

kokspflanze
Copy link
Contributor

just adding tests for php74

@kokspflanze kokspflanze changed the title added tests for php74 added tests for php74 WIP Jan 6, 2020
@kokspflanze kokspflanze changed the title added tests for php74 WIP added tests for php74 Jan 6, 2020
@svycka
Copy link
Collaborator

svycka commented Jan 7, 2020

maybe it's time to remove support for unsupported PHP versions. But not sure about this.

@kokspflanze
Copy link
Contributor Author

so we should only support php72- php74 right?
for me its no problem to drop the support for the old php versions

@svycka
Copy link
Collaborator

svycka commented Jan 7, 2020

I still use PHP 7.1 on some old projects but maybe its time to update. And if no one is against this then let's do this.

@basz
Copy link
Owner

basz commented Jan 7, 2020

I'm not using this anymore so for me no issue either...

looking at the packages statistics i would say its not a problem. just tag it as 0.5

@svycka svycka added this to the v0.5.0 milestone Jan 7, 2020
@svycka
Copy link
Collaborator

svycka commented Jan 10, 2020

@kokspflanze can you resolve conflicts and rebase? Or I will do just don't know when maybe next week

@kokspflanze
Copy link
Contributor Author

@svycka i will do it today in the evening=)

# Conflicts:
#	tests/SlmLocaleTest/Locale/DetectorTest.php
#	tests/SlmLocaleTest/ModuleTest.php
#	tests/SlmLocaleTest/Service/DetectFactoryTest.php
#	tests/SlmLocaleTest/Strategy/AssetStrategyTest.php
#	tests/SlmLocaleTest/Strategy/CookieStrategyTest.php
#	tests/SlmLocaleTest/Strategy/HostStrategyTest.php
#	tests/SlmLocaleTest/Strategy/HttpAcceptLanguageStrategyTest.php
#	tests/SlmLocaleTest/Strategy/QueryStrategyTest.php
#	tests/SlmLocaleTest/Strategy/UriPathStrategyTest.php
@basz
Copy link
Owner

basz commented Jan 10, 2020

PHP fixer fails. We either need to get a version that run on 74 or move the check to php73 (in travis config)

@kokspflanze
Copy link
Contributor Author

@basz yep, have to update my local php version to fix it^^

@basz basz merged commit 90155e1 into basz:develop Jan 11, 2020
@kokspflanze kokspflanze deleted the php74_tests branch January 20, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants