-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added tests for php74 #108
Conversation
tests with namespaces
maybe it's time to remove support for unsupported PHP versions. But not sure about this. |
so we should only support php72- php74 right? |
I still use PHP 7.1 on some old projects but maybe its time to update. And if no one is against this then let's do this. |
I'm not using this anymore so for me no issue either... looking at the packages statistics i would say its not a problem. just tag it as 0.5 |
@kokspflanze can you resolve conflicts and rebase? Or I will do just don't know when maybe next week |
@svycka i will do it today in the evening=) |
# Conflicts: # tests/SlmLocaleTest/Locale/DetectorTest.php # tests/SlmLocaleTest/ModuleTest.php # tests/SlmLocaleTest/Service/DetectFactoryTest.php # tests/SlmLocaleTest/Strategy/AssetStrategyTest.php # tests/SlmLocaleTest/Strategy/CookieStrategyTest.php # tests/SlmLocaleTest/Strategy/HostStrategyTest.php # tests/SlmLocaleTest/Strategy/HttpAcceptLanguageStrategyTest.php # tests/SlmLocaleTest/Strategy/QueryStrategyTest.php # tests/SlmLocaleTest/Strategy/UriPathStrategyTest.php
PHP fixer fails. We either need to get a version that run on 74 or move the check to php73 (in travis config) |
@basz yep, have to update my local php version to fix it^^ |
just adding tests for php74