Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions. #112

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Switch to GitHub Actions. #112

merged 1 commit into from
Nov 18, 2022

Conversation

demiankatz
Copy link
Contributor

@demiankatz demiankatz commented Nov 17, 2022

TODO

  • Make sure build is actually working.

@demiankatz demiankatz marked this pull request as draft November 17, 2022 19:14
@demiankatz demiankatz force-pushed the github-actions branch 3 times, most recently from f85127c to 4c868b0 Compare November 17, 2022 19:44
@demiankatz demiankatz marked this pull request as ready for review November 17, 2022 19:51
@demiankatz
Copy link
Contributor Author

This PR switches the project from Travis to GitHub actions for continuous integration. I believe it is functionally equivalent to the old configuration in most regards.

Some notes:

  • I had to update some Composer dependencies to make the build pass, but I only made the bare minimum changes to dev-only dependencies, so I think this should be harmless. (I had to raise the minimum version of php-cs-fixer to work around a notice that was causing the step to fail, and I had to add prophecy to get tests to run).
  • I tried to add a step to cache Composer dependencies, but I couldn't get it to work, and I ran out of time to keep tinkering. It should be okay without it, but caching would be a nice bonus. Feel free to borrow from https://github.com/vufind-org/vufind/blob/dev/.github/workflows/ci.yaml#L58-L67 -- I'm not sure why I couldn't get this to work in the context of the current project.
  • I dropped testing support for pre-7.4 PHP versions since they're all long past EOL. I added entries for PHP 8.0 and 8.1 but commented them out for now because they're not going to pass until we finish dependency update #110.

@demiankatz demiankatz mentioned this pull request Nov 17, 2022
@svycka svycka merged commit 8f2bd20 into basz:master Nov 18, 2022
@svycka svycka added this to the 1.0.0 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants