update of plotting recipes, modify plotting examples and add documentation of plotting

[Cornelius-G]

No description provided.

[VasylHafych]

Great! Can't wait to test this.

[codecov-io]

Codecov Report

Merging #121 into master will decrease coverage by 0.23%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   32.91%   32.68%   -0.24%     
==========================================
  Files          61       63       +2     
  Lines        3363     3390      +27     
==========================================
+ Hits         1107     1108       +1     
- Misses       2256     2282      +26     

Impacted Files	Coverage Δ
src/plotting/BATHistogram.jl	0.00% <0.00%> (ø)
src/plotting/BATHistogram_utils.jl	0.00% <0.00%> (ø)
src/plotting/recipes_BATHistogram_1D.jl	0.00% <0.00%> (ø)
src/plotting/recipes_BATHistogram_2D.jl	0.00% <0.00%> (ø)
src/plotting/recipes_ahmi.jl	0.00% <0.00%> (ø)
src/plotting/recipes_diagnostics.jl	0.00% <0.00%> (ø)
src/plotting/recipes_prior.jl	0.00% <0.00%> (ø)
src/plotting/recipes_prior_overview.jl	0.00% <0.00%> (ø)
src/plotting/recipes_samples_1D.jl	0.00% <0.00%> (ø)
src/plotting/recipes_samples_2D.jl	0.00% <0.00%> (ø)
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557acc9...ceffbe5. Read the comment docs.

[oschulz]

Great! Can't wait to test this.

@VasylHafych , please go right ahead, would be good to get some quick feedback. Just run

pkg> add BAT#7bacaae

[VasylHafych]

I am currently running long sampling, need ~2 hours to finish that. I will check right after that.

[oschulz]

Do you know why the docs build fails, @Cornelius-G ?

[Cornelius-G]

Oh, I'll take a look into this problem

[Cornelius-G]

Ah, there is a problem since the in the tutorial the prior contains multivariate distributions and we get a bounds error when trying to match the parameter index to a name. I did not yet manage to handle this kind of mapping names to indices of multivariate parameters. Thought when using indices it should work, but it is trying to get the corresponding name for the labels and then it fails. Guess I will first need to find a way to handle this properly...

[Cornelius-G]

Pushed a quick fix of this issue. Using the indices as labels for multivariate priors for now. But also started working on a better solution for handling the names of multivariate priors.

[oschulz]

But also started working on a better solution for handling the names of multivariate priors.

We should build part of that into ValueShapes at some point.

[Cornelius-G]

Hm, there still seems to be a problem when building the docs, but I'm not sure why. Might this be because I manually added a .md file with the plotting docu to the docs folder ? @oschulz

[oschulz]

@Cornelius-G , you can build the docs locally to find out what's wrong:

cd docs
export DOCUMENTER_DEBUG=true
julia --color=yes make.jl local

[oschulz]

What's the status on this?

[Cornelius-G]

There is still some problem building the docs, even when trying it locally:

[ Info: Populate: populating indices.
ERROR: LoadError: `makedocs` encountered errors. Terminating build
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] runner(::Type{Documenter.Builder.RenderDocument}, ::Documenter.Documents.Document) at /home/user/.julia/packages/Documenter/PLD7m/src/Builder.jl:242
 [3] dispatch(::Type{Documenter.Builder.DocumentPipeline}, ::Documenter.Documents.Document) at /home/user/.julia/packages/Documenter/PLD7m/src/Utilities/Selectors.jl:167
 [4] #2 at /home/user/.julia/packages/Documenter/PLD7m/src/Documenter.jl:240 [inlined]
 [5] cd(::Documenter.var"#2#3"{Documenter.Documents.Document}, ::String) at ./file.jl:104
 [6] #makedocs#1(::Bool, ::Documenter.Writers.HTMLWriter.HTML, ::Base.Iterators.Pairs{Symbol,Any,NTuple{7,Symbol},NamedTuple{(:sitename, :modules, :authors, :pages, :doctest, :linkcheck, :strict),Tuple{String,Array{Module,1},String,Array{Pair{String,String},1},Bool,Bool,Bool}}}, ::typeof(makedocs)) at /home/user/.julia/packages/Documenter/PLD7m/src/Documenter.jl:239
 [7] (::Documenter.var"#kw##makedocs")(::NamedTuple{(:sitename, :modules, :format, :authors, :pages, :doctest, :linkcheck, :strict),Tuple{String,Array{Module,1},Documenter.Writers.HTMLWriter.HTML,String,Array{Pair{String,String},1},Bool,Bool,Bool}}, ::typeof(makedocs)) at ./none:0
 [8] top-level scope at /home/user/Projects/julia/BAT.jl/docs/make.jl:27
 [9] include at ./boot.jl:328 [inlined]
 [10] include_relative(::Module, ::String) at ./loading.jl:1105
 [11] include(::Module, ::String) at ./Base.jl:31
 [12] exec_options(::Base.JLOptions) at ./client.jl:287
 [13] _start() at ./client.jl:460
in expression starting at /home/user/Projects/julia/BAT.jl/docs/make.jl:27

But I have no clue why that is. Except for adding one .md file to the docs folder, I did not change anything.

[oschulz]

@Cornelius-G , is this ready to merge, now?

[Cornelius-G]

Yes, I think so.

[oschulz]

@Cornelius-G , can you resolve the merge conflicts? Then I'll merge.

[Cornelius-G]

@oschulz Hm, where did you see the merge conflict? I can't seem to find it..

[oschulz]

Ah, sorry, just couldn't rebase, but merging is possible.

[oschulz]

Thanks!