OSPF: improvements to inter-area route propagation

[progwriter]

• Generate IA routes on initialization and import, as opposed to on export. This allows for better loop prevention by having a non-routing version of intra-area route as IA route in IA RIB.
• Implement split horizon rules for IA route propagation. Also helps loop prevention

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #6156 into master will decrease coverage by 0.01%.
The diff coverage is 95.83%.

@@             Coverage Diff              @@
##             master    #6156      +/-   ##
============================================
- Coverage     72.78%   72.77%   -0.02%     
+ Complexity    34718    34709       -9     
============================================
  Files          2816     2818       +2     
  Lines        141624   141646      +22     
  Branches      16985    16986       +1     
============================================
- Hits         103082   103080       -2     
- Misses        30386    30401      +15     
- Partials       8156     8165       +9     

Impacted Files	Coverage Δ	Complexity Δ
...org/batfish/dataplane/ibdp/OspfRoutingProcess.java	88.49% <95.83%> (-0.33%)	166.00 <10.00> (-4.00)
...rg/batfish/identifiers/StorageBasedIdResolver.java	88.88% <0.00%> (-4.45%)	27.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java	84.78% <0.00%> (-4.35%)	16.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java	89.58% <0.00%> (-4.17%)	27.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java	89.54% <0.00%> (-1.37%)	50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java	59.25% <0.00%> (-1.24%)	15.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java	86.36% <0.00%> (-0.91%)	259.00% <0.00%> (ø%)
...r/src/main/java/org/batfish/minesweeper/Graph.java	80.11% <0.00%> (-0.47%)	199.00% <0.00%> (-8.00%)
...a/org/batfish/representation/aws/LoadBalancer.java	82.18% <0.00%> (-0.32%)	70.00% <0.00%> (-1.00%)
... and 6 more

[dhalperi]

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @progwriter)

---

projects/batfish/src/test/java/org/batfish/dataplane/ibdp/OspfRoutingProcessTest.java, line 564 at r2 (raw file):

  @Test
  public void testConvertAndFilterIntraAreaRoutesToPropagate() {

I assume you've convinced yourself there's no important coverage lost?

[progwriter]

Reviewable status: complete! all files reviewed, all discussions resolved

---

projects/batfish/src/test/java/org/batfish/dataplane/ibdp/OspfRoutingProcessTest.java, line 564 at r2 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

I assume you've convinced yourself there's no important coverage lost?

yes, should be covered by testFilterInterAreaRoutesToPropagateAtABR since that still holds the required logic