Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize bgp and evpn rib questions #6795

Merged
merged 2 commits into from
Mar 28, 2021
Merged

Specialize bgp and evpn rib questions #6795

merged 2 commits into from
Mar 28, 2021

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Mar 27, 2021

Specialize the routes question for BGP and EVPN ribs. The questions have different columns in the answer tables, which are otherwise not visible in the documentation and left users wondering how they get BGP-specific fields.

@batfish-bot
Copy link

This change is Reviewable

@ratulm ratulm requested a review from saparikh March 27, 2021 04:25
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #6795 (a76faa7) into master (5bd17b1) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6795      +/-   ##
============================================
- Coverage     69.93%   69.91%   -0.02%     
+ Complexity    36294    36282      -12     
============================================
  Files          3026     3026              
  Lines        153390   153390              
  Branches      18417    18417              
============================================
- Hits         107274   107244      -30     
- Misses        37505    37525      +20     
- Partials       8611     8621      +10     
Impacted Files Coverage Δ Complexity Δ
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) 6.00% <0.00%> (-1.00%)
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) 22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.09% <0.00%> (-1.82%) 49.00% <0.00%> (-2.00%)
...main/java/org/batfish/datamodel/acl/AclTracer.java 62.89% <0.00%> (-1.26%) 43.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 84.50% <0.00%> (-0.93%) 249.00% <0.00%> (ø%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.42% <0.00%> (-0.70%) 245.00% <0.00%> (-3.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.50% <0.00%> (-0.31%) 210.00% <0.00%> (-1.00%)

Copy link
Contributor

@saparikh saparikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 5 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@saparikh saparikh merged commit 506b36f into master Mar 28, 2021
@saparikh saparikh deleted the bgp-evpn-rib branch March 28, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants