Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JunOS/Hierarchy: when generating preprocessed text, preserve user quotes #8205

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

dhalperi
Copy link
Member

No description provided.

@dhalperi dhalperi requested a review from arifogel March 30, 2022 23:46
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #8205 (fa1c5fe) into master (60e31b8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #8205      +/-   ##
============================================
- Coverage     74.49%   74.48%   -0.01%     
+ Complexity    43506    43500       -6     
============================================
  Files          3387     3387              
  Lines        168718   168718              
  Branches      20178    20179       +1     
============================================
- Hits         125691   125675      -16     
- Misses        33485    33496      +11     
- Partials       9542     9547       +5     
Impacted Files Coverage Δ
...ava/org/batfish/grammar/flatjuniper/Hierarchy.java 87.20% <100.00%> (ø)
...fish/bddreachability/BDDLoopDetectionAnalysis.java 83.82% <0.00%> (-2.95%) ⬇️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.47% <0.00%> (-0.62%) ⬇️
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 89.08% <0.00%> (-0.36%) ⬇️
...tfish/representation/cisco/CiscoConfiguration.java 84.56% <0.00%> (-0.16%) ⬇️
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 83.67% <0.00%> (-0.09%) ⬇️

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi merged commit 8c28293 into batfish:master Mar 31, 2022
@dhalperi dhalperi deleted the annotate branch March 31, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants