Support for grouping fields in admin #145
Conversation
|
Please review. Hi from PyCon US 2016 :) |
| if bit == 'in': | ||
| quotes = ('"', "'") | ||
| if remaining[1].startswith(quotes) and remaining[1].endswith(quotes): | ||
| remaining[1] = remaining[1][1:-1] |
There was a problem hiding this comment.
You should use unescape_string_literal here
https://docs.djangoproject.com/en/1.9/_modules/django/utils/text/
|
Just a little comment otherwise this seems good to go! Great feature implemented rather simply. |
|
Also what about being a little more explicit and use "group" or "groupby" as a keyword instead of "in"? |
|
I was thinking about "group by" but then it complicates parser code to get more tokens. |
|
Django template don't seem to use underscore: e.g. truncatewords, filesizeformat, intcomma so I would not go for group_by. What do you think of section? That seems to describe things very well? |
|
Yep, "section" is good. I will use it and rebase commits so we will have one history only:) |
remik
force-pushed
the
feature/grouping-fields-admin
branch
from
902a485
to
0d6d1d4
Compare
|
I know I can merge it but I will give you time for last check:) |
No description provided.