Django 1.10 support #168
Django 1.10 support #168
Conversation
| @@ -186,6 +186,9 @@ def language_mapping(lang): | |||
| COVERAGE_BRANCH_COVERAGE = False | |||
| PAGE_ENABLE_TESTS = True | |||
|
|
|||
| PASSWORD_HASHERS = [ | |||
| 'django.contrib.auth.hashers.SHA1PasswordHasher' | |||
There was a problem hiding this comment.
django.contrib.auth.hashers.MD5PasswordHasher would be faster
There was a problem hiding this comment.
Of course, but test fixtures contains SHA1 hashes.
There was a problem hiding this comment.
We could change it. I like changes to speedup development.
This is of course optional.
I was not involve in project for long time so will let @batiste to review it.
There was a problem hiding this comment.
Apart from the change of PAGE_USE_SITE_ID it looks all good to me.
| @@ -51,7 +51,7 @@ def on_site(self, site_id=None): | |||
|
|
|||
| :param site_id: specify the id of the site object to filter with. | |||
| """ | |||
| if settings.PAGE_USE_SITE_ID: | |||
| if global_settings.PAGE_USE_SITE_ID: | |||
There was a problem hiding this comment.
This will force the user to setup the PAGE_USE_SITE_ID setting isn't it? Is this really what we want?
| @@ -186,6 +186,9 @@ def language_mapping(lang): | |||
| COVERAGE_BRANCH_COVERAGE = False | |||
| PAGE_ENABLE_TESTS = True | |||
|
|
|||
| PASSWORD_HASHERS = [ | |||
| 'django.contrib.auth.hashers.SHA1PasswordHasher' | |||
There was a problem hiding this comment.
Apart from the change of PAGE_USE_SITE_ID it looks all good to me.
|
I've fixed the issue with default settings. |
It seems to work fine.