Reuse shared test workflow #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonkarns
force-pushed
the
workflow
branch
3 times, most recently
from
77e958a
to
4fd74f7
Compare
While the majority of use will likely not use npm, those that do will likely lock to particular versions. Once we have a lockfile, we'll be able to more easily jump to "old" versions and reproduce installation or compatibility issues. And with dependabot, we'll be able to still stay "fresh" and not worry about developer environments masking issues by not pulling newer versions.
The installation mechanism of dependencies is unique to a project, and so the configuration of BATS_LIB_PATH should be owned by the test suite, not assumed set as an outside env var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusable workflow in bats-core/.github, called here.