Fix/assert file owner requires sudo #38
Conversation
|
I'll come back to this as there is no way to test changes locally and there is a learning curve to figure out bits and bobs with Travis. |
|
While I decided to leave I found out I was using the wrong var name. Fixed it. However, again, I'll leave it to later as it fails something completely different and hard to figure/test etc. |
leventyalcin
force-pushed
the
fix/assert_file_owner_requires_sudo
branch
from
f51727e
to
d650dc5
Compare
[*] No ancient back-ticks (see shellcheck for instance) [*] No code block duplication
martin-schulze-vireso
force-pushed
the
fix/assert_file_owner_requires_sudo
branch
from
d650dc5
to
fdd71e8
Compare
|
I rebased this on master and removed the changes that duplicated my work in getting the unrelated tests green again. (I noticed too late that you did the same work.) |
| ### Why? | ||
|
|
||
| - Why Vagrant, not Docker | ||
| - This replicates the 100% CI |
There was a problem hiding this comment.
This does not hold anymore, since the CI is now migrated to GHA which offers only ubuntu. In the long run, I'd like to beef the CI up to test more of the OS fleet (Linux, MacOS, BSD, Windows, ...) as has been done with bats-core.
|
Thanks for your PR. |
…owner` Change the code of `assert_not_file_owner` to the version of `assert_file_owner` introduced in PR bats-core#38. The removal of the stray sudo calls fixes issue bats-core#49.
…owner` Change the code of `assert_not_file_owner` to the version of `assert_file_owner` introduced in PR bats-core#38. The removal of the stray sudo calls fixes issue bats-core#49.
This PR solves the problem mentioned in #37 and #27
(fixes #37, fixes #27)