Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the between sum_rate and reward? #9

Closed
Meblus199478 opened this issue Apr 18, 2023 · 7 comments
Closed

What's the between sum_rate and reward? #9

Meblus199478 opened this issue Apr 18, 2023 · 7 comments

Comments

@Meblus199478
Copy link

Meblus199478 commented Apr 18, 2023

I find the reward is defined as sum rate capacity, but I am confused why the sum rate doesn't equal reward in figures.

@baturaysaglam
Copy link
Owner

can you be more specific on that?

@Meblus199478
Copy link
Author

In figure 4, the sum rate is from 5 to 35
image
However, in figure 6, the reward is less than 10. In my opinion, our reward should be sum rate, so max reward should equal sum rate. Can you help me to solve that issue?
image

@baturaysaglam
Copy link
Owner

yes, there's an inconsistency between the two figures. however, note that the used hyperparameters are different for these figures; otherwise, they would've produced the same results. the authors didn't provide any hyperparameter setting for such particular learning curves, and I don't remember which hyperparameter values I used to produce Fig. 6 unfortunately. I've taken a look at the paper, but still couldn't find any information.

please let me know if anything else, and if you find the used hyperparameter values for Fig. 6.

@Meblus199478
Copy link
Author

Thank you for your reply. However, there is something weird. In figure 4, when I increase the number of RIS element (N), the result is getting worse, not like what you see in your figure 4. The following is my current figure 4 based on your code.
image

@baturaysaglam
Copy link
Owner

I believe this is expected since you increased the number of users as well. increasing the number of users would degrade the performance.

@Meblus199478
Copy link
Author

Thx for your explanation. I have changed the configuration, where the only distinction is the number of RIS element (N) like the following. By the way, I consider the sum rate in figure 4 may be the opt_reward rather than current_reward. opt_reward is the SNR rather than SINR. In that case, we will get larger sum rate.

image

@baturaysaglam
Copy link
Owner

yes, this is what's expected. when you increase the number of RIS elements, you'd obtain more transmission power as well as effective performance.

regarding the SNR/SINR, thank you for pointing this out, but I'm not the author of the paper, so I only tried to reproduce the figures more or less the same. authors didn't provide much detail such as which objective (as a reward) they used, hyperparameter settings, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants