Add favicon; suffix 'AVAA' to page names #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retokromer
reviewed
Jul 23, 2017
_layouts/default.html
Outdated
| <meta name="viewport" content="width=device-width"> | ||
| <link rel="stylesheet" href="{{ site.baseurl }}/css/syntax.css"> | ||
| <link rel="stylesheet" href="{{ site.baseurl }}/css/main.css"> | ||
| <link rel="stylesheet" href="{{ site.baseurl }}/css/responsive.css"> | ||
| <link rel="shortcut icon" type="image/x-icon" href="{{ site.baseurl}}/favicon.ico"> |
There was a problem hiding this comment.
Nit: in the other occurrences, there is a space also before }}.
|
Fixed! Cheers @retokromer. |
retokromer
approved these changes
Jul 23, 2017
|
Cool, I'll wait for @kellyhaydon or another BAVC person to suggest a favicon. |
|
That decision now lies with @iamdamosuzuki!!! |
|
Thank you @kfrn! I approve this and I think we can merge it in for now... and always upadate the favicon later. That VHS is what I use for my website! 😆 So I can recommend it as a good favicon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking on issues #134 and #135.
I generated a favicon from the AVAA logo - it doesn't really work at that scale, though. What do you all think? Maybe an AV-related emoji like 📼 would be better.