Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give an option for a toggle button on graphs to change y-axis min/max… #825

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

ElderOrb
Copy link
Collaborator

#822

@ElderOrb
Copy link
Collaborator Author

image

@ElderOrb
Copy link
Collaborator Author

Need an icon for new button:

image

@ElderOrb
Copy link
Collaborator Author

Need an icon for new button:

Still need an icon to complete PR.

@dericed ^^

@dericed
Copy link
Member

dericed commented Jun 22, 2024

  • For the icon, can you use signalserver_upload.png as a placeholder?

  • I'm testing with the U plot and setting to min/max of the plot but the lower edge of the y-axis is set to 0 on this regardless of the data.
    Here's a sample: ffmpeg -f lavfi -i color -vf geq=lum=0+N:cb=80+N:cr=255-N -t 3 yuvpattern.mkv. The U plot is a ramp from 80 to 154, but plot min/max plots at 0-154.

  • In custom I can enter a min value greater than the max value. Maybe if min>max then disable the Apply and highlight in red.

  • When you click Apply I suggest to close the modal window.

  • Some text changes: "Select y-axis min/max" -> "Set the y-axis range". "min/max value of the plot" -> "Fit to the plotted data", "system provided min/max" -> "Full Range". "custom" -> "Custom"

@dericed
Copy link
Member

dericed commented Jun 22, 2024

  • Move Full Range to first option and Fit to the plotted data to 2nd.

  • Also I suggest that we color code these settings. Full Range as black, Fit to dark blue, Custom to dark purple. The color should be shown either in the radio button in the selector or as a colored box to the left of the radio button. Then also use the color on the yaxis border and the numbered ticks on the left of the graph.

@dericed
Copy link
Member

dericed commented Jun 23, 2024

Looks good, though can we set a default for each plot?

@ElderOrb
Copy link
Collaborator Author

ElderOrb commented Jul 3, 2024

Looks good, though can we set a default for each plot?

Sure, any preferences on where should it be stored?

@dericed
Copy link
Member

dericed commented Jul 5, 2024

Looks good, though can we set a default for each plot?

Sure, any preferences on where should it be stored?

no preference, but if you add it, then I can set the default per plot

@dericed dericed merged commit 0950ff3 into bavc:main Jul 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants