This repository has been archived by the owner on Aug 3, 2019. It is now read-only.
[JENKINS-57747] Add validation for GitLab Server Url, take two #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was in order to fix #17 commits which had redundant commits. We removed the merged commit from develop and rebased develop on this branch and removed the additional commits and then squash merged into develop. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to validate a GitLab Server Url version from a public endpoint. The
/versionendpoint requires authentication. The only way is to fetch the projects from the server endpoint. If no public projects are at the endpoint, thegetProjectsmethod returnsnull.