This repository has been archived by the owner on Aug 3, 2019. It is now read-only.
[JENKINS-57884] Remove the need for using client api auth class #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baymac
requested review from
markjacksonfishing,
jetersen,
jeffpearce,
justinharringa and
LinuxSuRen
jeffpearce
approved these changes
Jun 6, 2019
|
I think it is better to remove it than keep it. 🤘 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @justinharringa here, I have removed the credentials matchers using auth models defined in the
client.apipackage as we do not have the overhead of dealing with api methods inside our plugin. So all authentication details can be fetched as follows:Token:
credentials.getToken().getPlainText()where credentials is of typePersonalAccessTokenUsername/Password
credentials.getUsername()/credentials.getPassword().getPlainText()where credentials is a genericStandardUsernamePasswordCredentialsI am keeping the models as it is for now, maybe it will be required in future else remove it.