Migrating bv-ui-pixels-displayed to module in the core #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## Module arguments | ||
|
|
||
| - `window`: Reference to window. |
There was a problem hiding this comment.
It won't need either of these, as it can use global.
msmolev
force-pushed
the
pixels-displayed
branch
from
67a1196
to
2cfdcdc
Compare
|
Updated structure to pull out the accessor for the testing purposes |
|
|
||
| function stubAccessor () { | ||
| sinonSandbox = sinon.sandbox.create(); | ||
| spy = sinonSandbox.spy(); |
There was a problem hiding this comment.
What's the intent here; the stub interface includes the spy interface, so anything you want to do with spy can be done with the stub.
msmolev
force-pushed
the
pixels-displayed
branch
from
2cfdcdc
to
93b8976
Compare
| } | ||
| ``` | ||
|
|
||
| ## License |
There was a problem hiding this comment.
The license block can be deleted - the license for the whole package is in the upper directory.
|
👍 Aside from items noted. |
msmolev
force-pushed
the
pixels-displayed
branch
from
93b8976
to
7afb527
Compare
|
Corrected the license notice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to migrate https://github.com/bazaarvoice/bv-ui-pixels-displayed into the core library.
Original library, however, only checked vertical visibility. So I have also duplicated the function and created horizontal version as well.
Migrated tests, created horizontal tests, added link in Readme.