chore: add bzlmod #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
bzlmod
branch
2 times, most recently
from
de0e767
to
3157586
Compare
jsharpe
reviewed
Feb 5, 2023
aherrmann
reviewed
Feb 6, 2023
14 tasks
So far the repo itself relies only on fetching via WORKSPACE, but produces a ruleset that users can consume with bzlmod Fixes #33
Co-authored-by: Andreas Herrmann <andreash87@gmx.ch>
aherrmann
reviewed
Feb 24, 2023
Comment on lines
+58
to
+61
| # Broken due to stardoc usage, see | ||
| # https://github.com/bazelbuild/stardoc/issues/117#issuecomment-1380744704 | ||
| - folder: . | ||
| bzlmodEnabled: true |
There was a problem hiding this comment.
An alternative could be to set --deleted_packages=docs. That will exclude //docs but will still be able to build and test the rest on CI.
There was a problem hiding this comment.
That would be nice... but there's no way to make that flag conditional on bzlmod so we'd have to introduce a --config like aspect-build/rules_js@48d0228#diff-874728f39b9bba99bc8a2949132b868dd74225faaa504ae43810a45516eaa613R76 (which has that complexity for exactly the same reason)
I hear commits are landing in Bazel to fix stardoc so I'd rather keep this simple and wait for a proper fix, I think
|
@aherrmann if this LGTY would you approve pls? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the repo itself relies only on fetching via WORKSPACE, but produces a ruleset that users can consume with bzlmod
Fixes #33