Move resolved_toolchain into the main workspace #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Awesome thanks! That's a clear improvement, I think it didn't even occur to me when I first borrowed this pattern from @illicitonion in rules_perl
|
FYI @kormide I'll start updating this in rules we forked from the template. |
alexeagle
reviewed
Feb 6, 2023
alexeagle
added a commit
to aspect-build/rules_swc
that referenced
this pull request
Feb 6, 2023
alexeagle
added a commit
to aspect-build/rules_esbuild
that referenced
this pull request
Feb 6, 2023
alexeagle
added a commit
to aspect-build/rules_swc
that referenced
this pull request
Feb 6, 2023
* refactor: move resolved_toolchain to the main workspace Similar to bazel-contrib/rules-template#48 * chore: re-introduce an alias to avoid breaking change
alexeagle
added a commit
to aspect-build/rules_esbuild
that referenced
this pull request
Feb 6, 2023
alexeagle
added a commit
to aspect-build/rules_esbuild
that referenced
this pull request
Feb 6, 2023
alexeagle
added a commit
to aspect-build/rules_esbuild
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47
Moves the
resloved_toolchainrule implementation into the main workspace.Defines a
resolved_toolchaintarget in the main workspace.Deletes
resolved_toolchainintoolchains_repo.