Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMD: fix other deprecated command line arguments #16

Conversation

rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Apr 4, 2022

Commit eac2e95 (#15) addressed the deprecation of -filelist by --file-list, but didn't consider other affected command line arguments.

The present change aims at paying that debt:

  • -auxclasspath by --aux-classpath,
  • -no-cache by --no-cache.

Short form arguments (-R, -f) are not affected.

See https://pmd.github.io/2021/11/27/PMD-6.41.0/

@rdesgroppes
Copy link
Contributor Author

@illicitonion sorry for having filed an incomplete PR.

Commit eac2e95 (bazel-contrib#15) addressed the
deprecation of `-filelist` by `--file-list`, but didn't consider other
affected command line arguments.

The present change aims at paying that debt:
- `-auxclasspath` by `--aux-classpath`,
- `-no-cache` by `--no-cache`.

Short form arguments (`-R`, `-f`) are *not* affected.

See https://pmd.github.io/2021/11/27/PMD-6.41.0/
@rdesgroppes rdesgroppes force-pushed the fix-other-deprecated-pmd-command-line-args branch from f102551 to b2a8963 Compare April 5, 2022 08:22
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thanks for the further fixes!

@illicitonion illicitonion merged commit 3fb934a into bazel-contrib:main Apr 5, 2022
@rdesgroppes
Copy link
Contributor Author

Thanks, Daniel!

@rdesgroppes rdesgroppes deleted the fix-other-deprecated-pmd-command-line-args branch April 5, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants