Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stamping for tags #70

Merged
merged 6 commits into from
Mar 10, 2023
Merged

stamping for tags #70

merged 6 commits into from
Mar 10, 2023

Conversation

alexeagle
Copy link
Collaborator

Fixes #69

@alexeagle alexeagle marked this pull request as ready for review March 9, 2023 17:40
@alexeagle alexeagle requested a review from thesayyn March 9, 2023 17:41
@alexeagle
Copy link
Collaborator Author

fyi @psalaberria002 in case you'd like to comment

@alexeagle alexeagle changed the title WIP: stamping stamping for tags Mar 9, 2023
@psalaberria002
Copy link
Contributor

fyi @psalaberria002 in case you'd like to comment

This solves stamping for tags, but not oci labels. Any thoughts on how to stamp the labels? It should be done when building the image ideally, not in oci_push.

@alexeagle
Copy link
Collaborator Author

Agreed, @thesayyn and I talked about that, anything that belongs in the image metadata will be a separate mechanism (maybe also using jq to produce stamped json, then merge that file in with other metadata we already control)

oci/defs.bzl Outdated Show resolved Hide resolved
examples/push/BUILD.bazel Outdated Show resolved Hide resolved
examples/push/BUILD.bazel Outdated Show resolved Hide resolved
oci/private/push.sh.tpl Show resolved Hide resolved
Copy link
Collaborator

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌🏻

@thesayyn thesayyn merged commit 6be1bcd into main Mar 10, 2023
@thesayyn thesayyn deleted the stamp branch March 10, 2023 11:21
alexeagle pushed a commit that referenced this pull request Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stamping
3 participants