Validate extension safety only on dynamic frameworks #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Summary Only validate the dynamic frameworks (those with `apple_common.AppleDynamicFramework`) when calling the `partials.extension_safe_validation_partial` partial. This mimics the `rules_apple` approach more correctly: https://github.com/bazelbuild/rules_apple/blob/eb5c03a606b103e9f8b72de954103eb00cf127f7/apple/internal/ios_rules.bzl#L1049-L1053
mattrobmattrob
added a commit
that referenced
this pull request
Jan 10, 2023
Update `rules_apple` to https://github.com/bazelbuild/rules_apple/releases/tag/2.0.0: - Handle bazelbuild/rules_apple@c23720d by adding `cc_info` param to `framework_provider_partial` call. - Handle bazelbuild/rules_apple@51d6273 by removing `bin_root_path`/`rule_label` param to `debug_symbols_partial` call. - Handle bazelbuild/rules_apple@a4de222 by removing the `apple_xcframework.framework_type` param. - Handle bazelbuild/rules_apple@02838e5 by self-identifying the `.modulemap` files in static/dynamic frameworks. - Work around bazelbuild/rules_apple#1797 by renaming a `NestedHeaders/` directory to `Nested/` for now. These parameter changes are likely breaking for folks with a different `rules_apple` so we'll want to take that into account before merging this PR. This is currently blocked by #632.
|
Somewhat stupidly, this was already merged as part of 9a705f8. 🤦 |
auto-merge was automatically disabled
January 24, 2023 20:12
Pull request was closed
mattrobmattrob
deleted the
mr/apply.extension.safety.validation.to.dynamic.fwks
branch
nataliejameson
pushed a commit
to discord/rules_ios
that referenced
this pull request
Aug 13, 2024
Update `rules_apple` to https://github.com/bazelbuild/rules_apple/releases/tag/2.0.0: - Handle bazelbuild/rules_apple@c23720d by adding `cc_info` param to `framework_provider_partial` call. - Handle bazelbuild/rules_apple@51d6273 by removing `bin_root_path`/`rule_label` param to `debug_symbols_partial` call. - Handle bazelbuild/rules_apple@a4de222 by removing the `apple_xcframework.framework_type` param. - Handle bazelbuild/rules_apple@02838e5 by self-identifying the `.modulemap` files in static/dynamic frameworks. - Work around bazelbuild/rules_apple#1797 by renaming a `NestedHeaders/` directory to `Nested/` for now. These parameter changes are likely breaking for folks with a different `rules_apple` so we'll want to take that into account before merging this PR. This is currently blocked by bazel-ios/rules_ios#632.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only validate the dynamic frameworks (those with
apple_common.AppleDynamicFramework) when calling thepartials.extension_safe_validation_partialpartial. This mimics therules_appleapproach more correctly:https://github.com/bazelbuild/rules_apple/blob/eb5c03a606b103e9f8b72de954103eb00cf127f7/apple/internal/ios_rules.bzl#L1049-L1053
Discovered this issue when playing around with
rules_apple_linkerand our app extensions since it's provided as adepsentry but not a classic example of what would be there.