Refactor _xcodeproj_is_mixed to _target_is_mixed #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohmcruz
approved these changes
May 19, 2023
| mixed = _xcodeproj_is_mixed(targets) | ||
|
|
||
| for target_info in targets: | ||
| mixed = _target_is_mixed(target_info) |
There was a problem hiding this comment.
Yeah, when I originally added that to detect mixed = True/False and then conditionally set -import-underlying-module later and didn't consider that we might want this per-target 😓.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
_xcodeproj_is_mixedto_target_is_mixedto determine the boolean value ofmixedon a per target basis.This change solves the following indexing error seen when indexing swift-only or objc-only targets on Xcode 14.3.0:
/<unknown>: underlying Objective-C module 'SomeSwiftOnly_App' not foundThanks to @thiagohmcruz for debugging this!