Improve performance of XcodeTarget.transitiveTargets() #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrymarino
approved these changes
Oct 8, 2018
| @@ -312,17 +312,25 @@ public class XcodeTarget: Hashable, Equatable { | |||
| return [] | |||
| } | |||
|
|
|||
| return unfilteredDependencies.flatMap { (xcodeTarget: XcodeTarget) -> [XcodeTarget] in | |||
| var transitiveTargets: [XcodeTarget] = [] | |||
| var queue = unfilteredDependencies | |||
jerrymarino
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XcodeTarget.transitiveTargets()traverses the dependency, and builds an array result usingflatMap. This wasn't showing up in traces of a small project with a smaller dependency graph, but in larger projects this hits some allocation slow paths in swift (swift_slowAlloc).This changes the graph traversal to be iterative, and brings big performance gains. Here are before and after samples:
Before
After