Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ actions don't report their env variables to Starlark properly #10376

Closed
hlopko opened this issue Dec 6, 2019 · 1 comment
Closed

C++ actions don't report their env variables to Starlark properly #10376

hlopko opened this issue Dec 6, 2019 · 1 comment
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: bug

Comments

@hlopko
Copy link
Member

hlopko commented Dec 6, 2019

Envrionment variables specified through feature configuration are not visible from Starlark, making it not possible to recreate C++ actions in Starlark on Darwin.
@hlopko hlopko self-assigned this Dec 6, 2019
@hlopko hlopko added P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules type: bug labels Dec 6, 2019
@hlopko hlopko assigned oquenchil and lberki and unassigned hlopko and oquenchil Feb 4, 2020
@oquenchil oquenchil added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Nov 19, 2020
copybara-service bot pushed a commit that referenced this issue Jul 29, 2022
@mai93 @copybara-github
Expose actions fixed environment variables specified through feature …
e82beda 
…configuration to Starlark

Some fixed environment variables are added to the actions environment [like CppCompile action](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java#L877) based on features configuration [code](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/rules/cpp/CompileCommandLine.java#L66). These variables can be available in the analysis phase.

This CL adds a flag `experimental_get_fixed_configured_action_env` to return these variables in `action.env`. This is needed to allow the use of aspects to output C++ actions information as a replacement for `print_action` command.

Addresses: #10376
PiperOrigin-RevId: 464088598
Change-Id: Id1c4e2badf5078d4d51f733aee8762411fd3b9ba
@oquenchil oquenchil closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hlopko @lberki @oquenchil and others