Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with OpenTelemetry #19158

Open
tbaing opened this issue Aug 3, 2023 · 4 comments
Open

Integrate with OpenTelemetry #19158

tbaing opened this issue Aug 3, 2023 · 4 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website team-Performance Issues for Performance teams type: feature request

Comments

@tbaing
Copy link
Contributor

tbaing commented Aug 3, 2023

Description of the feature request:

We're interested in having Bazel integrate with OpenTelemetry, with the idea that we'd like each build graph action to open a new span that links to the parent span for the overall Bazel invocation. This way, when our code invokes Bazel (inside an OTel span) and Bazel makes many actions that may invoke OTel-compatible tools we create, we'd be able to link the spans from those child tools to the specific Bazel action that spawned them rather than the overall Bazel process.

We recognize that the JSON profiles and the BEP provide two other ways to get (some of) this information, and that that might make implementing this third alternative somewhat unappealing. But Open Telemetry would let us link the processes Bazel invokes into the overall graph in a way that I don't believe those other two mechanisms can support, so we think it could still provide value despite the similarity to those other features.

Which category does this issue belong to?

No response

What underlying problem are you trying to solve with this feature?

We want to be able to capture OpenTelemetry traces across our full build, where Bazel will be invoked by scripts above it and will invoke scripts below it, to understand more details about our build's performance than are provided by Bazel's JSON profiling data alone.

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Aug 3, 2023
@iancha1992 iancha1992 removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Aug 3, 2023
@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Aug 4, 2023
@sgowroji sgowroji added team-Android Issues for Android team and removed team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Aug 4, 2023
@ahumesky ahumesky added team-Performance Issues for Performance teams team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website and removed team-Android Issues for Android team labels Aug 29, 2023
@ahumesky
Copy link
Contributor

This doesn't look specifically related to Android -- perhaps this is team-OSS or team-Performance

@meisterT meisterT added team-Performance Issues for Performance teams and removed team-Performance Issues for Performance teams labels Sep 5, 2023
@meisterT
Copy link
Member

meisterT commented Sep 5, 2023

cc @fweikert

@zhengwei143 zhengwei143 added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Sep 5, 2023
@goedelsoup-clari
Copy link

@tbaing, would the goal at this point be to align with the opentelemetry CI/CD initiative?

@tbaing
Copy link
Contributor Author

tbaing commented Jun 7, 2024

My immediate goal was to be able to invoke Bazel within a broader process that's instrumented via OpenTelemetry and have the Bazel actions captured within that OpenTelemetry profile so we don't need to manually integrate what Bazel produces into our OpenTelemetry profile. But of course implementing this could benefit other use cases beyond the one that prompted me to propose this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website team-Performance Issues for Performance teams type: feature request
Projects
None yet
Development

No branches or pull requests

8 participants