Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel-0.4.4: cannot bootstrap on Windows, latest MSYS #2473

Closed
laszlocsomor opened this issue Feb 2, 2017 · 6 comments
Closed

bazel-0.4.4: cannot bootstrap on Windows, latest MSYS #2473

laszlocsomor opened this issue Feb 2, 2017 · 6 comments
Assignees
Labels
P1 I'll work on this now. (Assignee required) platform: windows type: bug
Milestone

Comments

@laszlocsomor
Copy link
Contributor

Just downloaded the 0.4.4 dist zip, cannot bootstrap it on Windows with latest MSYS. It fails with Java compilation errors while compiling buildjar:

(...)
C:\Users\laszlocsomor\AppData\Local\Temp\bazel_O1pr7pGI\src\com\google\devtools\build\buildjar\proto\JavaCompilation.java:9: error: package com.google.protobuf does not exist
      com.google.protobuf.ExtensionRegistryLite registry) {
                         ^
C:\Users\laszlocsomor\AppData\Local\Temp\bazel_O1pr7pGI\src\com\google\devtools\build\buildjar\proto\JavaCompilation.java:13: error: package com.google.protobuf does not exist
      com.google.protobuf.ExtensionRegistry registry) {
                         ^
(...)
100 errors
9 warnings
@laszlocsomor laszlocsomor self-assigned this Feb 2, 2017
@laszlocsomor
Copy link
Contributor Author

Culprit: https://bazel-review.googlesource.com/c/8408/
This moved the PATHSEP reassignment on Windows into buildenv.sh which is sourced prior to compile.sh, the latter of which then sets PATHSEP to ":" unconditionally.

@laszlocsomor
Copy link
Contributor Author

Fixing that is not enough though, there's another breakage, apparently $JAVA_HOME isn't quoted somewhere:

# ./compile.sh
(...)
🍃  Building Bazel with Bazel.
.ERROR: Bad target pattern 'Files\Java\jdk1.8.0_112': package names may contain only A-Z, a-z, 0-9, '/', '-', '.' and '_'.
INFO: Elapsed time: 0.561s

ERROR: Could not build Bazel

@abergmeier-dsfishlabs
Copy link
Contributor

Can you fix this in a 0.4.4.1 or 0.4.5?

@laszlocsomor
Copy link
Contributor Author

Yes, we'll fix this after FOSDEM in the next release, whatever version that is. Sorry about the breakage, we didn't have test coverage for from-source bootstrapping on Windows.

@laszlocsomor
Copy link
Contributor Author

laszlocsomor commented Feb 3, 2017

For the time being, you can compile 0.4.3 from source (by applying a one-liner patch, see the known issues), then use that binary to build 0.4.4 / HEAD.

@abergmeier-dsfishlabs
Copy link
Contributor

For the time being, you can compile 0.4.3 from source (by applying a one-liner patch, see the known issues), then use that binary to build 0.4.4 or from HEAD.

No worries - I always keep working Bazel binaries around.

bazel-io pushed a commit that referenced this issue Feb 13, 2017
Fixes: #2520
Fixes one of the bugs causing #2473

--
PiperOrigin-RevId: 147335357
MOS_MIGRATED_REVID=147335357
@dslomov dslomov added this to the 0.5 milestone Feb 14, 2017
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
    Fixes: bazelbuild/bazel#2520
    Fixes one of the bugs causing bazelbuild/bazel#2473

    --
    PiperOrigin-RevId: 147335357
    MOS_MIGRATED_REVID=147335357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) platform: windows type: bug
Projects
None yet
Development

No branches or pull requests

4 participants