Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android_binary error message mentions non-existent attribute #3090

Closed
aj-michael opened this issue May 31, 2017 · 0 comments
Closed

android_binary error message mentions non-existent attribute #3090

aj-michael opened this issue May 31, 2017 · 0 comments
Assignees
@aj-michael
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee)

Comments

@aj-michael
Copy link
Contributor

When building an android_binary with no manifest attribute, the build fails with a message like this:

ERROR: /usr/local/google/home/ajmichael/bazel/a/examples/android/java/bazel/BUILD:12:1: in manifest attribute of android_binary rule //examples/android/java/bazel:hello_world: a resources or manifest attribute is mandatory.

However, there is no resources attribute on android_binary.
@aj-michael aj-michael added category: rules > android P3 We're not considering working on this, but happy to review a PR. (No assignee) labels May 31, 2017
@aj-michael aj-michael self-assigned this May 31, 2017
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Make android_binary.manifest mandatory.
b909bf7 
    It was already effectively mandatory. The build would fail if you did not have
    the manifest attribute set, but this provides a better error message.

    Fixes bazelbuild/bazel#3090.

    RELNOTES: None
    PiperOrigin-RevId: 157719024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aj-michael aj-michael

Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aj-michael