-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most actions ignore --action_env #3320
Comments
@laszlocsomor updated some of the Android actions to do this properly. |
is there any progress? |
I fixed the C++ actions recently, but there are still a bunch missing. |
I also fixed the symlink tree action. |
I noticed that when compiling protobuf, the env vars specified by Bazel version: 0.15.0 (from release). Failure message:
Dependency chain:
Is there a way to circumvent this? +@creachadair Update: I found protocolbuffers/protobuf#2508 which sounds related, but you are likely better suited to sort it out between bazel and protobuf than me. Thank you. |
@robinp Which version of bazel are you on? You need a bazel binary that includes the changes I made in May. |
Bazel version:
I execute For example, a good subcommand:
A failing subcommand:
I can observe that the failing subcommand doesn't have the Thanks! |
Ok, Bazel 0.16 seems to have most of my problems fixed. For the remaining: Could you clarify how should
and using this rule seems to not use the |
See #3320 PiperOrigin-RevId: 220493622
I'm still having this issue with protobuf when trying to bootstrap Bazel 0.21.0 using:
The only way I can get it to work is by setting --noincompatible_strict_action_env so that Bazel does not use a static PATH environment variable. |
Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen (or ping me to reopen) if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so. |
I mostly want to file this so I can add todos to the code. 6e940e5 added a new abstraction for tracking the environment, and we need to update all actions (and all callers) to use the new abstraction, and use it consistently, i.e., not randomly drop env variables.
The text was updated successfully, but these errors were encountered: