Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI, rules_closure: broken on all platforms #3385

Closed
laszlocsomor opened this issue Jul 14, 2017 · 3 comments
Closed

CI, rules_closure: broken on all platforms #3385

laszlocsomor opened this issue Jul 14, 2017 · 3 comments
Assignees
Labels
breakage P1 I'll work on this now. (Assignee required)

Comments

@laszlocsomor
Copy link
Contributor

laszlocsomor commented Jul 14, 2017

http://ci.bazel.io/job/rules_closure/BAZEL_VERSION=HEAD,PLATFORM_NAME=ubuntu_16.04-x86_64/937/console

ERROR: /home/ci/workspace/rules_closure/BAZEL_VERSION/HEAD/PLATFORM_NAME/linux-x86_64/closure/testing/BUILD:32:1: Doing library-level typechecking of //closure/testing:phantomjs_harness failed (Exit 1): ClosureWorker failed: error executing command bazel-out/host/bin/java/io/bazel/rules/closure/ClosureWorker JsCompiler --checks_only --incremental_check_mode CHECK_IJS --warning_level VERBOSE --jscomp_off reportUnknownTypes --language_in ... (remaining 7 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox.
closure/testing/phantomjs_harness.js:26: ERROR - variable require is undeclared
var webpage = /** @type {!phantomjs.WebPage} */ (require('webpage'));
                                                 ^
  Codes: JSC_UNDEFINED_VARIABLE, checkVars, missingSourcesWarnings, undefinedVars

closure/testing/phantomjs_harness.js:218: ERROR - variable phantom is undeclared
  phantom.exit(1);
  ^
  Codes: JSC_UNDEFINED_VARIABLE, checkVars, missingSourcesWarnings, undefinedVars

2 error(s), 0 warning(s)

cc: @buchgr

@laszlocsomor laszlocsomor added breakage P1 I'll work on this now. (Assignee required) labels Jul 14, 2017
@laszlocsomor
Copy link
Contributor Author

needs bisecting

@laszlocsomor
Copy link
Contributor Author

Culprit is 8002b62, same as #3388

@meteorcloudy
Copy link
Member

OK, I can also confirm reverting 8002b62 fixed the problem.

luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
    *** Reason for rollback ***

    Broke various Bazel CI jobs

    Fixes bazelbuild/bazel#3388
    Fixes bazelbuild/bazel#3386
    Fixes bazelbuild/bazel#3385
    Fixes bazelbuild/bazel#3384

    *** Original change description ***

    Fix rules that provide both 'executable' and 'files'

    PiperOrigin-RevId: 161949099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakage P1 I'll work on this now. (Assignee required)
Projects
None yet
Development

No branches or pull requests

3 participants