Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the Java runfiles library to @bazel_tools//tools/java/runfiles #5803

Closed
laszlocsomor opened this issue Aug 8, 2018 · 2 comments
Closed
Assignees

Comments

@laszlocsomor
Copy link
Contributor

Description of the problem / feature request:

Every language's runfiles library is under @bazel_tools//tools/<language>/runfiles, Java being the only exception with @bazel_tools//tools/runfiles:java-runfiles.

Feature requests: what underlying problem are you trying to solve with this feature?

Consistency with other languages.

What's the output of bazel info release?

  $ bazel info release
release 0.16.0

Any other information, logs, or outputs that you want to share?

#5802 is not a blocker, but an annoyance, because we can't just add a deprecation attribute to @bazel_tools//tools/runfiles:java-runfiles telling users which target to use instead.

@laszlocsomor
Copy link
Contributor Author

Workaround for the time being (because of #5802):

  • add a new java_library to src/tools/runfiles/java/com/google/devtools/build/runfiles/BUILD.tools called "runfiles-deprecated" with a deprecation attribute
  • change the alias rule in tools/runfiles/BUILD.tools to point to "runfiles-deprecated"
  • add a new java_library to tools/java/runfiles/BUILD.tools that uses the sources from //src/tools/runfiles/java/com/google/devtools/build/runfiles:java-srcs.

@laszlocsomor
Copy link
Contributor Author

This workaround is not good enough: it warns against the alias rule, not against the rule that depends on the alias, i.e. Bazel will warn against @bazel_tools//tools/runfiles:java-runfiles, not against the rule that depends on @bazel_tools//tools/runfiles:java-runfiles (as we would like to).

laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Aug 8, 2018
See bazelbuild#5803

Change-Id: I49a2e744af667d34aedc3384629acd48641b0921
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Aug 8, 2018
See bazelbuild#5803

Change-Id: I49a2e744af667d34aedc3384629acd48641b0921
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Aug 8, 2018
See bazelbuild#5803

Change-Id: I49a2e744af667d34aedc3384629acd48641b0921
bazel-io pushed a commit that referenced this issue Aug 9, 2018
See #5803

Change-Id: I49a2e744af667d34aedc3384629acd48641b0921

Closes #5804.

Change-Id: I75f85f02384fd1d9f6ebac5fff7c96c7278f7cdd
PiperOrigin-RevId: 208010815
iirina pushed a commit that referenced this issue Aug 13, 2018
Move the Java runfiles library's sources from
//src/tools/runfiles/j/c/g/devtools/build/runfiles:*
to //tools/java/runfiles.

Fixes #5803

RELNOTES[NEW]: Java, runfiles: the Java runfiles library is now in @bazel_tools//tools/java/runfiles. The old target (@bazel_tools//tools/runfiles:java-runfiles) is deprecated and will be removed in Bazel 0.18.0.

PiperOrigin-RevId: 208191521
laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Oct 17, 2018
This change deletes the Java runfiles target from
@bazel_tools//tools/runfiles:java-runfiles, as its
deprecation message said Bazel 0.19.0 would.

The new target to use is
@bazel_tools//tools/java/runfiles

Fixed bazelbuild#5803

Change-Id: I8faebb9dc3759d4732d3a53e236e315e58147545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant