Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if Python 2 values are specified #887

Merged
merged 6 commits into from
Dec 1, 2022
Merged

Fail if Python 2 values are specified #887

merged 6 commits into from
Dec 1, 2022

Conversation

rickeylev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Python 2 usages of the rules will immediately fail. Examples include:

py_binary(..., python_version="PY2")
py_library(..., srcs_version="PY2")
py_runtime_pair(..., py2_runtime="//something")

Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f0rmiga
Copy link
Collaborator

f0rmiga commented Dec 1, 2022

@rickeylev could you resolve the conflicts, please? I'd like to merge this for the next minor release.

Regnerate docs from main
@rickeylev
Copy link
Contributor Author

Well, I had intended to merge in January as part of the new year, but...Yeah, lets just do it now. Worst case we find out sooner and can just revert it.

@f0rmiga
Copy link
Collaborator

f0rmiga commented Dec 1, 2022

All good if you want to wait a bit more.

@rickeylev rickeylev merged commit ce977e1 into bazelbuild:main Dec 1, 2022
@rickeylev rickeylev mentioned this pull request Dec 1, 2022
3 tasks
@rickeylev rickeylev deleted the fail-py2 branch December 1, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants