Consider DEVELOPER_DIR when building wrapped_clang #11719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
force-pushed
the
wrapped_clang-DEVELOPER_DIR
branch
from
2ce1812
to
770bdf7
Compare
brentleyjones
force-pushed
the
wrapped_clang-DEVELOPER_DIR
branch
from
770bdf7
to
b52ca16
Compare
|
bump |
brentleyjones
force-pushed
the
wrapped_clang-DEVELOPER_DIR
branch
from
b52ca16
to
ddfe61a
Compare
|
Rebased to resolve conflict. |
|
@allevato Friendly ping |
allevato
approved these changes
Oct 21, 2020
|
@philwo Is this able to get in for 3.8? |
|
@brentleyjones Yes! :) Submitting it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11716, which partially addresses #8902. With this change, and some careful environment manipulation (probably in a wrapper script) you can ensure that
wrapped_clangis built with the correct version of Xcode.