Generate rules/cpp/cc_configure.WORKSPACE from distdir_deps.bzl rather than keeping it in sync by hand #12743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a capability to generate WORKSPACE files for tests at build time, based on the repository definitions in distdir_deps.bzl. This makes it possible for the versions of repositories used in tests to align with the versions used a Bazel build time without upddating files scattered throughout the source and test trees. Demonstrated with rules_cc.
…r than keeping it in sync by hand
aiuto
commented
Dec 23, 2020
meteorcloudy
approved these changes
Jan 5, 2021
|
This PR is unexpectedly difficult to import. It passes all CI from this side, but when imported to Google and reexported it fails to build a correct bazel. That is, the bazel runs, but is missing the cc_configure.WORKSPACE resource. But the strange part is that the generated file is in bazel-distfile.zip and in the deploy jar. And that makes sense, because we should not even be able to build bazel (with bazel) without having that file correctly generated. So my suspicion is that we are building a bootstrap bazel directly from java sources, without bazel - and we are testing with that version, and that process is not actually using distfile.zip, but is instead relying on the github sources. I have more to explore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate rules/cpp/cc_configure.WORKSPACE from distdir_deps.bzl rather than keeping it in sync by hand.
More progress on #12081.
Create a capability to generate WORKSPACE files for tests at build time, based on the repository definitions in distdir_deps.bzl.
This makes it possible for the versions of repositories used in tests to align with the versions used a Bazel build time without upddating files scattered throughout the source and test trees.
Demonstrated with rules_cc.