Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up minor issues in C++/Java tutorials #1530

Closed
wants to merge 1 commit into from
Closed

Clean up minor issues in C++/Java tutorials #1530

wants to merge 1 commit into from

Conversation

d9n
Copy link
Contributor

@d9n d9n commented Jul 16, 2016

Hello, I work for Google but am currently contributing this as an individual. I'm interested in learning Bazel on the side, and as I'm going through the docs, I thought I'd submit code reviews for misc. Bazel site cleanup that I came across (especially for guides that act as a first impression for new users).

Let me know if you'd prefer I submit this patch in a different way. Thanks!

@bazel-io
Copy link
Member

Can one of the admins verify this patch?

* Writing and running C++ test
* Using precompiled libraries
* Use external libraries
* Write and running C++ test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/running/run/

@katre katre self-assigned this Jul 18, 2016
@d9n
Copy link
Contributor Author

d9n commented Jul 22, 2016

Thanks for proofreading! I patched the pull request with the substitution. (This is the first time I've done this through GitHub so let me know if the changes didn't come through)

@bazel-io bazel-io closed this in 4545ef5 Jul 22, 2016
steren pushed a commit to bazelbuild/bazel-website that referenced this pull request Apr 26, 2017
Hello, I work for Google but am currently contributing this as an individual. I'm interested in learning Bazel on the side, and as I'm going through the docs, I thought I'd submit code reviews for misc. Bazel site cleanup that I came across (especially for guides that act as a first impression for new users).

Let me know if you'd prefer I submit this patch in a different way. Thanks!

Closes #1530.

--
Reviewed-on: bazelbuild/bazel#1530
MOS_MIGRATED_REVID=128174882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants