ProxyHelper handles proxy URLs with trailing slash. #1597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two missing test cases. 1. Trailing slash in proxy URL. 2. No user:password provided in proxy URL.
|
Can one of the admins verify this patch? |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Notifying @kchodorow, who seems to have worked on the ProxyHelper before. |
|
Jenkins, test this please. |
|
LGTM, the build failure is unrelated. Please sign the CLA and I'll merge this in. |
|
CLA: 'I signed it!' |
|
CLAs look good, thanks! |
luca-digrazia
pushed a commit
to luca-digrazia/DatasetCommitsDiffSearch
that referenced
this pull request
Sep 5, 2022
Having a proxy URL defined with a trailing slash caused an exception. `Proxy address ... is not a valid URL"` This pull request fixes this issue.
I also added two test cases for this issue. 1. Trailing slash in proxy URL. 2. No
user:password provided in proxy URL.
Closes #1597.
--
Reviewed-on: bazelbuild/bazel#1597
MOS_MIGRATED_REVID=129721433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a proxy URL defined with a trailing slash caused an exception.
Proxy address ... is not a valid URL"This pull request fixes this issue.I also added two test cases for this issue. 1. Trailing slash in proxy URL. 2. No
user:password provided in proxy URL.