Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find libtool when using BAZEL_USE_CPP_ONLY_TOOLCHAIN. #16010

Closed
wants to merge 2 commits into from
Closed

Find libtool when using BAZEL_USE_CPP_ONLY_TOOLCHAIN. #16010

wants to merge 2 commits into from

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Jul 31, 2022 •
edited
Loading

Instead of hardcoding /usr/bin/libtool which requires Xcode / Xcode CLT installed, which BAZEL_USE_CPP_ONLY_TOOLCHAIN is meant to avoid.

Related to #16009.

@uri-canva
Find libtool when using BAZEL_USE_CPP_ONLY_TOOLCHAIN.
c5375b3 
Instead of hardcoding `/usr/bin/libtool` which requires Xcode / Xcode CLT installed, which `BAZEL_USE_CPP_ONLY_TOOLCHAIN` is meant to avoid.
@uri-canva
Add environment variable to repository rule.
fdc1731
@uri-canva uri-canva mentioned this pull request Jul 31, 2022
Merged
13 tasks
@sgowroji sgowroji added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Aug 1, 2022
This was referenced Aug 9, 2022
Open
Closed
oquenchil
oquenchil approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@oquenchil oquenchil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@oquenchil oquenchil self-assigned this Dec 16, 2022
@oquenchil oquenchil added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 20, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 23, 2023
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 23, 2023
@ShreeM01
Copy link
Contributor

@bazel-io fork 6.1.0

@bazel-io bazel-io mentioned this pull request Jan 25, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 25, 2023
@ShreeM01 ShreeM01 mentioned this pull request Jan 25, 2023
Merged
ShreeM01 added a commit that referenced this pull request Jan 27, 2023
@ShreeM01 @uri-canva
Find libtool when using BAZEL_USE_CPP_ONLY_TOOLCHAIN. (#17327)
17ac479 
Instead of hardcoding `/usr/bin/libtool` which requires Xcode / Xcode CLT installed, which `BAZEL_USE_CPP_ONLY_TOOLCHAIN` is meant to avoid.

Related to #16009.

Closes #16010.

PiperOrigin-RevId: 503922158
Change-Id: I64392ada951938d612dd0b28141e6b2e4ee6952c

Co-authored-by: Uri Baghin <uri@canva.com>
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@uri-canva @hvadehra
Find libtool when using BAZEL_USE_CPP_ONLY_TOOLCHAIN.
2249a99 
Instead of hardcoding `/usr/bin/libtool` which requires Xcode / Xcode CLT installed, which `BAZEL_USE_CPP_ONLY_TOOLCHAIN` is meant to avoid.

Related to #16009.

Closes #16010.

PiperOrigin-RevId: 503922158
Change-Id: I64392ada951938d612dd0b28141e6b2e4ee6952c
@uri-canva uri-canva mentioned this pull request Nov 1, 2023
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil oquenchil approved these changes

Assignees

@oquenchil oquenchil

Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@uri-canva @brentleyjones @ShreeM01 @oquenchil @bazel-io @sgowroji