Implement worker support for GenerateDataBindingBaseClasses
#16067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkumar9t2
force-pushed
the
worker-support-for-gen-base-classes
branch
from
bcfc71f
to
c0edd1c
Compare
arunkumar9t2
force-pushed
the
worker-support-for-gen-base-classes
branch
from
c0edd1c
to
fcd08b5
Compare
sgowroji
added
team-Android
|
We probably want this to be ported over to |
1 similar comment
|
We probably want this to be ported over to |
This is the corresponding code in the starlark rules: But we can still merge this for Bazel 7.0 |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenerateDataBindingBaseClassestoResourceProcessorBusyBoxsince Android databinding classes were already a dependency there.ProcessDatabindingis already part ofResourceProcessorBusyBoxbut it was not enabled inpersistent_android_resource_processorexpansion flag. Added that as well.This change is multiplex compatible and probably could use expansion flags as done here #15950.
Results:
In a synthetic generated project with 30 modules here https://github.com/arunkumar9t2/bazel-playground, the worker can be turned off/on with
.bazel.sh build //android/databinding_workers:android_data_binding --strategy=GenerateDataBindingBaseClasses=[sandboxed|worker]and worker is about 9 to 10% faster.